hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8649) ChecksumFileSystem should have an overriding implementation of listStatus(Path, PathFilter)
Date Tue, 07 Aug 2012 19:19:10 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430545#comment-13430545
] 

Daryn Sharp commented on HADOOP-8649:
-------------------------------------

What I _think_ I see in trunk is:
# (A) {{ChecksumFileSystem#listStatus(Path, PathFilter)}} calls (B) {{ChecksumFileSystem#listStatus(Path)}}
# (B) {{ChecksumFileSystem#listStatus(Path)}} calls (C) {{fs.listStatus(Path, ChecksumFileSystem.DEFAULT_FILTER)}}
to filter out crcs
# (A) {{ChecksumFileSystem#listStatus(Path, PathFilter)}} further filters the crc filtered
results with the custom {{PathFilter}}

Do your test cases show this analysis is wrong?  Or did you notice it through casual observation
of the code?  Perhaps a composite {{PathFilter}} is more efficient on large directory listings,
but I'm curious if there's actually a bug.
                
> ChecksumFileSystem should have an overriding implementation of listStatus(Path, PathFilter)
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8649
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8649
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: HADOOP-8649_branch1.patch, HADOOP-8649_branch1.patch_v2, HADOOP-8649_branch1.patch_v3
>
>
> Currently, ChecksumFileSystem implements only listStatus(Path). The other form of listStatus(Path,
PathFilter) is implemented by parent class FileSystem, and hence doesn't filter out check-sum
files.
> The implementation should use a composite filter of passed Filter and the Checksum filter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message