hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8736) Create a Builder to make an RPC server
Date Tue, 28 Aug 2012 15:49:08 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443226#comment-13443226
] 

Aaron T. Myers commented on HADOOP-8736:
----------------------------------------

bq. Typo: method name "setProt" should be "setProto"

Agree it's a typo, but I think it should be "setPort".

bq. Some of the values while building protocol engine, such as protocol, instance, etc. cannot
have default values. It would be good to either add check for that in Builder or ensure it
is is checked in getProtocolEngine() implementation.

Or perhaps those required fields should be set as part of the Builder constructor, while the
other fields are set via the builder set*() methods?
                
> Create a Builder to make an RPC server
> --------------------------------------
>
>                 Key: HADOOP-8736
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8736
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 3.0.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HADOOP-8736.patch, HADOOP-8736.patch
>
>
> There are quite a few variants of getServer() method to create an RPC server. Create
a builder class to abstract the building steps and avoid more getServer() variants in the
future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message