hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8736) Create a Builder to make an RPC server
Date Wed, 29 Aug 2012 20:57:08 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444406#comment-13444406
] 

Suresh Srinivas commented on HADOOP-8736:
-----------------------------------------

bq. But like I said, you can go with whatever you prefer. You haven't convinced me that this
is the right way to go, but I'm not going to stop you from doing it.
I am fine with the current approach being taken. If there are issue due to this approach,
because of frequent changes in Server, we could always revisit this.

Here are comments for the patch (mostly nits):
# build() method, please follow the coding guidelines and have {} after if.
# Throwing HadoopIllegalArgumentException is fine. But if you are doing that for two of the
parameters, I suggest doing the same for handlerCount and conf parameter as well.
# In javadoc for build() method please add @throws and say if mandator fields are not set,
the build method will throw HadoopIllegalArgumentException.
# Please add a testcase where you create RPC server without mandatory fields and ensure exceptions
are thrown. We could perhaps add this to TestIPC.
                
> Create a Builder to make an RPC server
> --------------------------------------
>
>                 Key: HADOOP-8736
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8736
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 3.0.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HADOOP-8736.patch, HADOOP-8736.patch, HADOOP-8736.patch
>
>
> There are quite a few variants of getServer() method to create an RPC server. Create
a builder class to abstract the building steps and avoid more getServer() variants in the
future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message