hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8581) add support for HTTPS to the web UIs
Date Thu, 09 Aug 2012 13:16:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431785#comment-13431785
] 

Aaron T. Myers commented on HADOOP-8581:
----------------------------------------

Patch looks pretty good to me, Tucu. Just a few small comments:

# Per our coding conventions, I don't think that HttpConfig#SSL_ENABLED should be all caps.
# In the HttpServer constructor, move the .setHost and .setPort to after the if/else:
{code}
if (...) {
...
  sslListener.setHost(bindAddress);
  sslListener.setPort(port);
  listener = sslListener;
} else {
  listener = createBaseListener(conf);
  listener.setHost(bindAddress);
  listener.setPort(port);
}
{code}
# In the core-default.xml description, take out the word "it" and change "webuis" to "web
UIs":
{code}
+    Whether to use SSL for the HTTP endpoints. If set to true, it the
+    NameNode, DataNode, ResourceManager, NodeManager, HistoryServer and
+    MapReduceAppMaster webuis will be served over HTTPS instead HTTP.
{code}
# Rather than go through the headache of writing out a core-default.xml containing the appropriate
SSL config, how about just adding a setSslEnabledForTesting static function to HttpConfig?
# Considering that every place you call HttpConfig#getScheme you immediately append "://",
maybe just append that in HttpConfig#getScheme? Or perhaps have a HttpConfig#getPrefix which
returns HttpConfig#getScheme() + "://" ?
# I think you inadvertently incorrectly changed the indentation in HostUtil#getTaskLogUrl
to be 4 spaces instead of 2.
# There are some inadvertent and unnecessary whitespace changes in RMAppAttemptImpl.
                
> add support for HTTPS to the web UIs
> ------------------------------------
>
>                 Key: HADOOP-8581
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8581
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: security
>    Affects Versions: 2.0.0-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.1.0-alpha
>
>         Attachments: HADOOP-8581.patch, HADOOP-8581.patch, HADOOP-8581.patch, HADOOP-8581.patch,
HADOOP-8581.patch
>
>
> HDFS/MR web UIs don't work over HTTPS, there are places where 'http://' is hardcoded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message