hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8698) Do not call unneceseary setConf(null) in Configured constructor
Date Tue, 14 Aug 2012 23:55:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434658#comment-13434658
] 

Hadoop QA commented on HADOOP-8698:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12540877/setconf-null.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1296//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1296//console

This message is automatically generated.
                
> Do not call unneceseary setConf(null) in Configured constructor
> ---------------------------------------------------------------
>
>                 Key: HADOOP-8698
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8698
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.23.3, 3.0.0
>            Reporter: Radim Kolar
>            Priority: Minor
>             Fix For: 0.23.3, 3.0.0
>
>         Attachments: setconf-null.txt
>
>
> no-arg constructor of /org/apache/hadoop/conf/Configured calls setConf(null). This is
unnecessary and it increases complexity of setConf() code because you have to check for not
null object reference before using it. Under normal conditions setConf() is never called with
null reference, so not null check is unnecessary.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message