Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Tue, 3 Jul 2012 20:46:35 +0000 (UTC)
From: "Suresh Srinivas (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <892810005.369.1341348395282.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <954507320.22527.1321050891550.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-7818) DiskChecker#checkDir should fail
 if the directory is not executable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406027#comment-13406027 ] 

Suresh Srinivas commented on HADOOP-7818:
-----------------------------------------

Eli, since you have the context of this jira, can you please review and commit the patch, if you have time? If you are busy, I will commit the patch.
                
> DiskChecker#checkDir should fail if the directory is not executable
> -------------------------------------------------------------------
>
>                 Key: HADOOP-7818
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7818
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Eli Collins
>            Assignee: madhukara phatak
>            Priority: Minor
>         Attachments: HADOOP-7818-1.patch, HADOOP-7818-2.patch, HADOOP-7818.patch
>
>
> DiskChecker#checkDir fails if a directory can't be created, read, or written but does not fail if the directory exists and is not executable. This causes subsequent code to think the directory is OK but later fail due to an inability to access the directory (eg see MAPREDUCE-2921). I propose checkDir fails if the directory is not executable. Looking at the uses, this should be fine, I think it was ignored because checkDir is often used to create directories and it creates executable directories.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira