hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-8531) SequenceFile Writer can throw out a better error if a serializer isn't available
Date Wed, 11 Jul 2012 06:13:35 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Harsh J updated HADOOP-8531:
----------------------------

    Attachment: HADOOP-8531-2.patch

Your patch looks good so I went ahead and additionally added the error message enhancements
(to note configs) and also added in checks for the deserializer (they were not present, unsure
what you meant when you said they were - what am I missing?)

This new patch uses proper writer/reader constructors for sequence files as well, instead
of the deprecated constructors that existed in the patch previously.

{code}
Running org.apache.hadoop.io.TestSequenceFile
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.4 sec
{code}

Added tests pass, as shown above.

I'll commit this in after jenkins gives its +1. Thanks Madhukara!
                
> SequenceFile Writer can throw out a better error if a serializer isn't available
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-8531
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8531
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Harsh J
>            Assignee: madhukara phatak
>            Priority: Trivial
>              Labels: newbie
>         Attachments: HADOOP-8531-1.patch, HADOOP-8531-2.patch, HADOOP-8531.patch
>
>
> Currently, if the provided Key/Value class lacks a proper serializer in the loaded config
for the SequenceFile.Writer, we get an NPE as the null return goes unchecked.
> Hence we get:
> {code}
> java.lang.NullPointerException
> 	at org.apache.hadoop.io.SequenceFile$Writer.init(SequenceFile.java:1163)
> 	at org.apache.hadoop.io.SequenceFile$Writer.<init>(SequenceFile.java:1079)
> 	at org.apache.hadoop.io.SequenceFile$RecordCompressWriter.<init>(SequenceFile.java:1331)
> 	at org.apache.hadoop.io.SequenceFile.createWriter(SequenceFile.java:271)
> {code}
> We can provide a better message + exception in such cases. This is slightly related to
MAPREDUCE-2584.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message