hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Graves (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8573) Configuration tries to read from an inputstream resource multiple times.
Date Tue, 10 Jul 2012 14:09:36 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410363#comment-13410363
] 

Thomas Graves commented on HADOOP-8573:
---------------------------------------

Mostly looks good, a couple minor things.

nits:
- add a space in Configuration.java line 1772 and 1905 after if before (  and 1926 between
for and (

suggestions:
- could add a comment describing new behavior when using InputStreams - perhaps a warning
about memory usage
- we might change org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.loadConfFile to use
addResource(Path file) instead of the inputStream. Only used in one place right now but might
be better to change it in case it gets used more. 
                
> Configuration tries to read from an inputstream resource multiple times. 
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-8573
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8573
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 1.0.2, 0.23.3, 2.0.1-alpha, 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8573.txt
>
>
> If someone calls Configuration.addResource(InputStream) and then reloadConfiguration
is called for any reason, Configruation will try to reread the contents of the InputStream,
after it has already closed it.
> This never showed up in 1.0 because the framework itself does not call addResource with
an InputStream, and typically by the time user code starts running that might call this, all
of the default and site resources have already been loaded.
> In 0.23 mapreduce is now a client library, and mapred-site.xml and mapred-default.xml
are loaded much later in the process.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message