hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8434) TestConfiguration currently has no tests for direct setter methods
Date Tue, 03 Jul 2012 18:27:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405966#comment-13405966
] 

Suresh Srinivas commented on HADOOP-8434:
-----------------------------------------

Made a minor update to the patch - line was more than 80 columns and removed unnecessary IOExceptions
(throws in the existing code and not in the code from the patch).
                
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8434
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8434
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: madhukara phatak
>              Labels: newbie
>         Attachments: HADOOP-8434-1.patch, HADOOP-8434-2.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better
to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for
the each of the setter methods, although other projects' tests do test this extensively.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message