Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 21 Jun 2012 16:43:42 +0000 (UTC)
From: "Jack Dintruff (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <959515250.39633.1340297022527.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1677111530.39180.1340292403377.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Updated] (HADOOP-8523) test-patch.sh doesn't validate
 patches before building
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jack Dintruff updated HADOOP-8523:
----------------------------------

    Attachment: Hadoop-8523.patch

Just moved the smart-apply-patch.sh call to run after setup as per Jon's suggestion..
                
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
>                 Key: HADOOP-8523
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8523
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.23.3
>            Reporter: Jack Dintruff
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.23.3
>
>         Attachments: Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid.  It would help devs if it checked first just in case we run test-patch.sh with a bad patch file. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira