Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 690A4C2FC for ; Wed, 20 Jun 2012 09:29:45 +0000 (UTC) Received: (qmail 76768 invoked by uid 500); 20 Jun 2012 09:29:44 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 76384 invoked by uid 500); 20 Jun 2012 09:29:43 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 76350 invoked by uid 99); 20 Jun 2012 09:29:43 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2012 09:29:43 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 50A1D141F4C for ; Wed, 20 Jun 2012 09:29:43 +0000 (UTC) Date: Wed, 20 Jun 2012 09:29:43 +0000 (UTC) From: "Hadoop QA (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1422228831.33267.1340184583332.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1701648443.29412.1336172269032.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-8362) Improve exception message when Configuration.set() is called with a null key or value MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397374#comment-13397374 ] Hadoop QA commented on HADOOP-8362: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532674/HADOOP-8362-8.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 13 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1125//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1125//console This message is automatically generated. > Improve exception message when Configuration.set() is called with a null key or value > ------------------------------------------------------------------------------------- > > Key: HADOOP-8362 > URL: https://issues.apache.org/jira/browse/HADOOP-8362 > Project: Hadoop Common > Issue Type: Improvement > Components: conf > Affects Versions: 2.0.0-alpha > Reporter: Todd Lipcon > Assignee: madhukara phatak > Priority: Trivial > Labels: newbie > Attachments: HADOOP-8362-1.patch, HADOOP-8362-2.patch, HADOOP-8362-3.patch, HADOOP-8362-4.patch, HADOOP-8362-5.patch, HADOOP-8362-6.patch, HADOOP-8362-7.patch, HADOOP-8362-8.patch, HADOOP-8362.patch > > > Currently, calling Configuration.set(...) with a null value results in a NullPointerException within Properties.setProperty. We should check for null key/value and throw a better exception. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira