Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 21 Jun 2012 17:41:42 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <1406139245.39880.1340300502843.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1677111530.39180.1340292403377.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
 patches before building
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398628#comment-13398628 ] 

Hadoop QA commented on HADOOP-8523:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12532902/Hadoop-8523.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 javadoc.  The javadoc tool appears to have generated 13 warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1131//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1131//console

This message is automatically generated.
                
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
>                 Key: HADOOP-8523
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8523
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.3, 2.0.1-alpha
>            Reporter: Jack Dintruff
>            Priority: Trivial
>              Labels: newbie
>         Attachments: Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid.  It would help devs if it checked first just in case we run test-patch.sh with a bad patch file. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira