Return-Path: 
 <common-issues-return-32452-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B01FD9A70
	for <apmail-hadoop-common-issues-archive@minotaur.apache.org>;
 Wed,  6 Jun 2012 13:48:23 +0000 (UTC)
Received: (qmail 59774 invoked by uid 500); 6 Jun 2012 13:48:23 -0000
Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org
Received: (qmail 59743 invoked by uid 500); 6 Jun 2012 13:48:23 -0000
Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:common-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:common-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:common-issues@hadoop.apache.org>
List-Id: <common-issues.hadoop.apache.org>
Reply-To: common-issues@hadoop.apache.org
Delivered-To: mailing list common-issues@hadoop.apache.org
Received: (qmail 59735 invoked by uid 99); 6 Jun 2012 13:48:23 -0000
Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2012 13:48:23 +0000
Received: from isssues-vm.apache.org (localhost [127.0.0.1])
	by issues-vm (Postfix) with ESMTP id 56CC814002E
	for <common-issues@hadoop.apache.org>; Wed,  6 Jun 2012 13:48:23 +0000 (UTC)
Date: Wed, 6 Jun 2012 13:48:23 +0000 (UTC)
From: "Daryn Sharp (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <1102032232.43651.1338990503357.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1666678983.27232.1338568763239.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HADOOP-8464) hadoop-env.sh is included twice:
 once via hadoop-config.sh the again explicitly via scripts
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HADOOP-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290156#comment-13290156 ] 

Daryn Sharp commented on HADOOP-8464:
-------------------------------------

Won't we lose the ability to override values if it does an absolute set?  I'd think the script should only set the value if unset.  Ie. something like: {code}${KEY:=<default value or expression>}{code}

I agree that technically it would be safe to include hadoop-env multiple times although it would be good to avoid redundant and unnecessary includes where possible.
                
> hadoop-env.sh is included twice: once via hadoop-config.sh the again explicitly via scripts
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8464
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8464
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 2.0.0-alpha
>            Reporter: Jay Finger
>
> Many (most? all?) scripts include hadoop-env.sh twice.  The first time is indirectly:  scripts do ". hadoop-config.sh" and hadoop-config.sh then does ". hadoop-env.sh".  Then scripts will later directly do ". hadoop-env.sh".
> This double-include is error prone.
> Note several Jira's reporting issues with HADOOP_LOG_DIR set to /user/user (e.g. /root/root, /hadoop/hadop, etc).  This is because hadoop-env.sh has done "HADOOP_LOG_DIR=$HADOOP_LOG_DIR/$user".  Many fixes for those issues are around addressing that one line, but it seems that this is going to be a recurring theme of breakages.  It's probably also why services are routinely started with many command line arguments repeated multiple times.
> I'm not familiar enough with the "design" of all the scripts, so not sure what the solution should be.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira