Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 230559DD9 for ; Thu, 7 Jun 2012 19:30:24 +0000 (UTC) Received: (qmail 62323 invoked by uid 500); 7 Jun 2012 19:30:23 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 62296 invoked by uid 500); 7 Jun 2012 19:30:23 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 62288 invoked by uid 99); 7 Jun 2012 19:30:23 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jun 2012 19:30:23 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id AB9DE140BEF for ; Thu, 7 Jun 2012 19:30:23 +0000 (UTC) Date: Thu, 7 Jun 2012 19:30:23 +0000 (UTC) From: "Ivan Mitic (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1091855857.49300.1339097423706.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1871149209.13350.1337334010403.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-8409) Address Hadoop path related issues on Windows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291240#comment-13291240 ] Ivan Mitic commented on HADOOP-8409: ------------------------------------ bp. Not a big deal, but Path(parent,child) can be used in a couple places instead of a string concat. Fixed bp. Would a Path#toFile() that I mentioned in a related jira maybe help in a few cases? Hm... not sure I see it. Did you maybe think of using {{new Path(file).toUri()}} instead? > Address Hadoop path related issues on Windows > --------------------------------------------- > > Key: HADOOP-8409 > URL: https://issues.apache.org/jira/browse/HADOOP-8409 > Project: Hadoop Common > Issue Type: Bug > Components: fs, test, util > Affects Versions: 1.0.0 > Reporter: Ivan Mitic > Assignee: Ivan Mitic > Attachments: HADOOP-8409-branch-1-win.2.patch, HADOOP-8409-branch-1-win.3.patch, HADOOP-8409-branch-1-win.patch > > Original Estimate: 168h > Remaining Estimate: 168h > > There are multiple places in prod and test code where Windows paths are not handled properly. From a high level this could be summarized with: > 1. Windows paths are not necessarily valid DFS paths (while Unix paths are) > 2. Windows paths are not necessarily valid URIs (while Unix paths are) > #1 causes a number of tests to fail because they implicitly assume that local paths are valid DFS paths (by extracting the DFS test path from for example "test.build.data" property) > #2 causes issues when URIs are directly created on path strings passed in by the user -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira