hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8521) Port StreamInputFormat to new Map Reduce API
Date Wed, 27 Jun 2012 10:40:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402127#comment-13402127
] 

Steve Loughran commented on HADOOP-8521:
----------------------------------------

also, some code style issues
# ASF comment should appear at top of files
# some of the files have different indentation policy from the Hadoop code -an IDE can fix
that.
# variables marked as {{final static}} in {{StreamXmlRecordReader}} should be private or protected
unless there is a very good reason for package scoping.

The thing that worries me most is the call to {{init()}} in the constructor of StreamXmlRecordReader.
Unless that class or method is final, there's the risk that a subclass will have its init()
method called before that subclass is fully initialized, which leads to bad things. 

If moving the init phase out of the constructor isn't possible because of the way Hadoop instantiates
& uses the reader, then that class or method ought to be final.
                
> Port StreamInputFormat to new Map Reduce API
> --------------------------------------------
>
>                 Key: HADOOP-8521
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8521
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.23.0
>            Reporter: madhukara phatak
>            Assignee: madhukara phatak
>         Attachments: HADOOP-8521-1.patch, HADOOP-8521-2.patch, HADOOP-8521.patch
>
>
> As of now , hadoop streaming uses old Hadoop M/R API. This JIRA ports it to the new M/R
API.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message