hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmed Radwan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8484) Prevent Configuration getter methods that are passed a default value from throwing RuntimeException
Date Tue, 05 Jun 2012 19:15:23 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289652#comment-13289652
] 

Ahmed Radwan commented on HADOOP-8484:
--------------------------------------

The only issue I have is that there are cases where it is helpful for it to crash to alarm
for the incorrect configuration and there are cases where picking the default is just appropriate
and will enhance the fault-tolerance. But I agree with you, the generalization here in Configuration
may not be the right choice, and it is better to handle this on a case-by-case basis, so the
code reading the property can decide to catch the exception if needed. I am closing this one.
                
> Prevent Configuration getter methods that are passed a default value from throwing RuntimeException
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8484
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8484
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 2.0.0-alpha
>            Reporter: Ahmed Radwan
>             Fix For: 2.0.1-alpha
>
>
> Configuration getter methods that are passed default values can throw RuntimeExceptions
if the value provided is invalid (e.g. NumberFormatException).
> In many cases such exception results in more serious consequences (failure to sart a
service, see for example NodeManager DeletionService). This can be avoided by returning the
default value and just printing a warning message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message