hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate patches before building
Date Fri, 22 Jun 2012 20:17:43 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399564#comment-13399564
] 

Jonathan Eagles commented on HADOOP-8523:
-----------------------------------------

Great! A couple of more things from the new patch. test-patch.sh now aborts at the proper
place. We will want to make sure the jira comment is posted to notify the user, similar to
how applyPatch is being used. smart-apply-patch.sh looks like it will have the correct results.
Also smart patch is getting a bit complicated with its option parsing. Either as part of this
JIRA or a new JIRA add getopts parsing to be more robust and extensible with parsing.
                
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
>                 Key: HADOOP-8523
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8523
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.23.3, 2.0.1-alpha
>            Reporter: Jack Dintruff
>            Priority: Minor
>              Labels: newbie
>         Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that
doesn't compile, the script spends a lot of time building Hadoop before checking to see if
the patch is invalid.  It would help devs if it checked first just in case we run test-patch.sh
with a bad patch file. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message