hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8469) Make NetworkTopology class pluggable and support user specified topology class
Date Mon, 04 Jun 2012 15:02:23 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288611#comment-13288611
] 

Hadoop QA commented on HADOOP-8469:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530784/HADOOP-8468-total-v3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified test files.

    -1 javac.  The applied patch generated 1997 javac compiler warnings (more than the trunk's
current 1996 warnings).

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common
hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1080//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1080//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1080//artifact/trunk/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1080//console

This message is automatically generated.
                
> Make NetworkTopology class pluggable and support user specified topology class
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-8469
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8469
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 1.0.0, 2.0.0-alpha
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: HADOOP-8469-NetworkTopology-pluggable-v2.patch, HADOOP-8469-NetworkTopology-pluggable.patch
>
>
> The class NetworkTopology is where the three-layer hierarchical topology is modeled in
the current code base and is instantiated directly by the DatanodeManager and Balancer.
> To support alternative topologies, changes were make the topology class pluggable, that
is to support using a user specified topology class specified in the Hadoop configuration
file core-defaul.xml. The user specified topology class is instantiated using reflection in
the same manner as other customizable classes in Hadoop. If no use specified topology class
is found, the fallback is to use the NetworkTopology to preserve current behavior. To make
it possible to reuse code in NetworkTopology several minor changes were made to make the class
more extensible. The NetworkTopology class is currently annotated with @InterfaceAudience.LimitedPrivate({"HDFS",
"MapReduce"}) and @InterfaceStability.Unstable.
> The proposed changes in NetworkTopology listed below
> 1. Some fields were changes from private to protected
> 2. Added some protected methods so that sub classes could override behavior
> 3. Added a new method,isNodeGroupAware,to NetworkTopology
> 4. The inner class InnerNode was made a package protected class to it would be easier
to subclass

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message