hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate patches before building
Date Thu, 21 Jun 2012 16:33:42 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398550#comment-13398550
] 

Jonathan Eagles commented on HADOOP-8523:
-----------------------------------------

Thanks for the patch, Jack. I like that this will save me some time as I know I have hit this
case before.

Couple of comments. There are two mode this script runs in, from Jenkins to run the commit
builds and by developers for testing purposes. Jenkins mode relies on setup to download the
patch file from the JIRA, so the check will need to happen after the patch is downloaded.
Additionally, setup needs an unpatched build to check if trunk is stable and determine pre-patched
javac warnings. Perhaps by adding a --dry-run option to smart-apply-patch this can be achieved.
                
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
>                 Key: HADOOP-8523
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8523
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.23.3
>            Reporter: Jack Dintruff
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.23.3
>
>         Attachments: Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that
doesn't compile, the script spends a lot of time building Hadoop before checking to see if
the patch is invalid.  It would help devs if it checked first just in case we run test-patch.sh
with a bad patch file. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message