hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-8488) test-patch.sh gives +1 even if the native build fails.
Date Thu, 07 Jun 2012 18:50:23 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Colin Patrick McCabe updated HADOOP-8488:
-----------------------------------------

    Description: It seems that Jenkins doesn't fail the build if the native part of the build
doesn't succeed.  This should be fixed!  (was: It would be nice if Jenkins would compile with
mvn compile -Pnative or a similar command line.

Currently, we don't seem to build the native code at all when testing patches. Unfortunately,
this allows patches that break the native parts of the build to go in without the usual testing.

It's true that the Jenkins build would not catch all native code issues (it only compiles
in one environment, and there may be #ifdefs). However, some testing is sure better than none.
I believe with cmake the performance overhead of -Pnative should be very minimal.

This would also allow us to run the junit tests which depend on native code, and the raw native
unit tests in Jenkins.
)
    
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
>                 Key: HADOOP-8488
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8488
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-8488.001.patch
>
>
> It seems that Jenkins doesn't fail the build if the native part of the build doesn't
succeed.  This should be fixed!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message