Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E23A99DCD for ; Sat, 5 May 2012 10:36:12 +0000 (UTC) Received: (qmail 98598 invoked by uid 500); 5 May 2012 10:36:12 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 98532 invoked by uid 500); 5 May 2012 10:36:11 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 98514 invoked by uid 99); 5 May 2012 10:36:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 May 2012 10:36:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 May 2012 10:36:10 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id DD56B431E22 for ; Sat, 5 May 2012 10:35:49 +0000 (UTC) Date: Sat, 5 May 2012 10:35:49 +0000 (UTC) From: "Junping Du (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <825061719.30179.1336214149920.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2058263656.4388.1335177455679.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-8304) DNSToSwitchMapping should add interface to resolve individual host besides a list of host MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268933#comment-13268933 ] Junping Du commented on HADOOP-8304: ------------------------------------ That's good comments on compatibility of this change. I saw evolving tag there but not consider people extends DNSToSwitchMapping as well (just thought ScriptBased, TableMapping and cached are good enough). I won't say original interface cause some performance headache as the time of resolving rack info can be overwhelmed comparing with the whole flow (replica placement or task scheduling). However, it is more easy to use for major consumers of original interface which are expecting to resolve individual host. Do you see any scenario to resolve a list of host? (not counting the unit test) Eli, I don't understand the question of last comment there as I just want to fix the interface here. :) > DNSToSwitchMapping should add interface to resolve individual host besides a list of host > ----------------------------------------------------------------------------------------- > > Key: HADOOP-8304 > URL: https://issues.apache.org/jira/browse/HADOOP-8304 > Project: Hadoop Common > Issue Type: Improvement > Components: io > Affects Versions: 1.0.0, 2.0.0 > Reporter: Junping Du > Assignee: Junping Du > Fix For: 2.0.0 > > Attachments: HADOOP-8304-V2.patch, HADOOP-8304-V2.patch, HADOOP-8304.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > DNSToSwitchMapping now has only one API to resolve a host list: public List resolve(List names). But the two major caller: RackResolver.resolve() and DatanodeManager.resolveNetworkLocation() are taking single host name but have to wrapper it to an single entry ArrayList. This is not necessary especially the host has been cached before. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira