Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Tue, 1 May 2012 20:06:50 +0000 (UTC)
From: "Tsz Wo (Nicholas), SZE (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <603976048.14269.1335902810963.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2094039770.14032.1335899330340.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-8340) SNAPSHOT build versions should
 compare as less than their eventual final release
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266019#comment-13266019 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-8340:
------------------------------------------------

Looks good.  Minor comments:
- remove System.err.println
- Use com.google.common.collect.ComparisonChain, i.e.
{code}
    return ComparisonChain.start()
        .compare(version1Parts.length, version2Parts.length)
        .compare(isSnapshot2, isSnapshot1)
        .result();
{code}

                
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-8340
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8340
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira