Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF9DE9D3A for ; Fri, 18 May 2012 09:06:47 +0000 (UTC) Received: (qmail 54033 invoked by uid 500); 18 May 2012 09:06:47 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 52740 invoked by uid 500); 18 May 2012 09:06:41 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 52612 invoked by uid 99); 18 May 2012 09:06:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 May 2012 09:06:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 May 2012 09:06:35 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2037FBF9E for ; Fri, 18 May 2012 09:06:14 +0000 (UTC) Date: Fri, 18 May 2012 09:06:14 +0000 (UTC) From: "madhukara phatak (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1508156970.13263.1337331974140.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <954507320.22527.1321050891550.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HADOOP-7818) DiskChecker#checkDir should fail if the directory is not executable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] madhukara phatak updated HADOOP-7818: ------------------------------------- Attachment: HADOOP-7818-1.patch updated patch with testcase change > DiskChecker#checkDir should fail if the directory is not executable > ------------------------------------------------------------------- > > Key: HADOOP-7818 > URL: https://issues.apache.org/jira/browse/HADOOP-7818 > Project: Hadoop Common > Issue Type: Bug > Components: util > Affects Versions: 0.20.205.0, 0.23.0, 0.24.0 > Reporter: Eli Collins > Assignee: Eli Collins > Priority: Minor > Attachments: HADOOP-7818-1.patch, HADOOP-7818.patch > > > DiskChecker#checkDir fails if a directory can't be created, read, or written but does not fail if the directory exists and is not executable. This causes subsequent code to think the directory is OK but later fail due to an inability to access the directory (eg see MAPREDUCE-2921). I propose checkDir fails if the directory is not executable. Looking at the uses, this should be fine, I think it was ignored because checkDir is often used to create directories and it creates executable directories. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira