Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Tue, 29 May 2012 14:01:24 +0000 (UTC)
From: "Harsh J (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <1260629128.11054.1338300084106.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <1701648443.29412.1336172269032.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-8362) Improve exception message when
 Configuration.set() is called with a null key or value
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284821#comment-13284821 ] 

Harsh J commented on HADOOP-8362:
---------------------------------

Hi Madhukara,

I do appreciate (and love) your enthusiasm in providing new, review-fixing patches but please do test your patch locally for simple things such as compiler errors and test runs before you send it across. Surely a local compile can help us save a lot of time.

You can also run a test-patch.sh run locally to test your patch yourself first, instead of relying on the QA queue, which is for reviewed patches alone.

Thanks and please keep contributing!
Harsh
                
> Improve exception message when Configuration.set() is called with a null key or value
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8362
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8362
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 2.0.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: madhukara phatak
>            Priority: Trivial
>              Labels: newbie
>         Attachments: HADOOP-8362-1.patch, HADOOP-8362-2.patch, HADOOP-8362-3.patch, HADOOP-8362-4.patch, HADOOP-8362-5.patch, HADOOP-8362.patch
>
>
> Currently, calling Configuration.set(...) with a null value results in a NullPointerException within Properties.setProperty. We should check for null key/value and throw a better exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira