Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A4AA98DD for ; Fri, 18 May 2012 15:45:40 +0000 (UTC) Received: (qmail 41283 invoked by uid 500); 18 May 2012 15:45:40 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 41139 invoked by uid 500); 18 May 2012 15:45:40 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 41123 invoked by uid 99); 18 May 2012 15:45:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 May 2012 15:45:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 May 2012 15:45:35 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id DEBBFCF44 for ; Fri, 18 May 2012 15:45:13 +0000 (UTC) Date: Fri, 18 May 2012 15:45:13 +0000 (UTC) From: "Hadoop QA (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1144911905.14429.1337355913914.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1701648443.29412.1336172269032.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-8362) Improve exception message when Configuration.set() is called with a null key or value MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278884#comment-13278884 ] Hadoop QA commented on HADOOP-8362: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12528070/HADOOP-8362-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.io.TestMapFile org.apache.hadoop.fs.TestFilterFileSystem org.apache.hadoop.fs.viewfs.TestViewFileSystemDelegation org.apache.hadoop.http.lib.TestStaticUserWebFilter org.apache.hadoop.fs.viewfs.TestViewFsTrash org.apache.hadoop.io.file.tfile.TestTFileStreams org.apache.hadoop.util.TestGenericOptionsParser org.apache.hadoop.ipc.TestSaslRPC org.apache.hadoop.ipc.TestMultipleProtocolServer org.apache.hadoop.conf.TestReconfiguration org.apache.hadoop.ipc.TestSocketFactory org.apache.hadoop.fs.viewfs.TestViewfsFileStatus org.apache.hadoop.io.file.tfile.TestTFile org.apache.hadoop.ipc.TestProtoBufRpc org.apache.hadoop.fs.TestFsShellReturnCode org.apache.hadoop.conf.TestConfigurationDeprecation org.apache.hadoop.io.serializer.TestWritableSerialization org.apache.hadoop.io.TestGenericWritable org.apache.hadoop.io.file.tfile.TestTFileSplit org.apache.hadoop.fs.s3native.TestInMemoryNativeS3FileSystemContract org.apache.hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs org.apache.hadoop.net.TestScriptBasedMapping org.apache.hadoop.fs.TestS3_LocalFileContextURI org.apache.hadoop.security.TestSecurityUtil org.apache.hadoop.util.TestGenericsUtil org.apache.hadoop.fs.viewfs.TestFcPermissionsLocalFs org.apache.hadoop.fs.TestTruncatedInputBug org.apache.hadoop.ipc.TestRPCCallBenchmark org.apache.hadoop.http.TestHttpServerLifecycle org.apache.hadoop.fs.TestTrash org.apache.hadoop.security.TestGroupsCaching org.apache.hadoop.io.TestDefaultStringifier org.apache.hadoop.security.TestUserGroupInformation org.apache.hadoop.log.TestLogLevel org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsByteArrays org.apache.hadoop.conf.TestGetInstances org.apache.hadoop.ha.TestZKFailoverController org.apache.hadoop.io.file.tfile.TestTFileSeqFileComparison org.apache.hadoop.ha.TestHealthMonitor org.apache.hadoop.fs.permission.TestFsPermission org.apache.hadoop.io.compress.TestCodec org.apache.hadoop.fs.TestFileSystemCanonicalization org.apache.hadoop.net.TestTableMapping org.apache.hadoop.security.TestLdapGroupsMapping org.apache.hadoop.fs.shell.TestPathData org.apache.hadoop.ipc.TestServer org.apache.hadoop.fs.viewfs.TestFcMainOperationsLocalFs org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsJClassComparatorByteArrays org.apache.hadoop.http.TestHttpServerWebapps org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem org.apache.hadoop.ipc.TestRPC org.apache.hadoop.http.TestGlobalFilter org.apache.hadoop.security.authorize.TestProxyUsers org.apache.hadoop.io.file.tfile.TestTFileSeek org.apache.hadoop.fs.viewfs.TestViewFsConfig org.apache.hadoop.fs.viewfs.TestFcCreateMkdirLocalFs org.apache.hadoop.fs.TestLocal_S3FileContextURI org.apache.hadoop.io.file.tfile.TestTFileByteArrays org.apache.hadoop.ha.TestSshFenceByTcpPort org.apache.hadoop.io.file.tfile.TestTFileUnsortedByteArrays org.apache.hadoop.ipc.TestMiniRPCBenchmark org.apache.hadoop.fs.s3.TestInMemoryS3FileSystemContract org.apache.hadoop.ipc.TestIPC org.apache.hadoop.conf.TestConfServlet org.apache.hadoop.cli.TestCLI org.apache.hadoop.io.file.tfile.TestTFileComparator2 org.apache.hadoop.security.TestAuthenticationFilter org.apache.hadoop.fs.viewfs.TestViewFileSystemDelegationTokenSupport org.apache.hadoop.fs.viewfs.TestViewFsLocalFs org.apache.hadoop.conf.TestDeprecatedKeys org.apache.hadoop.conf.TestConfiguration org.apache.hadoop.io.serializer.avro.TestAvroSerialization org.apache.hadoop.fs.TestLocalDirAllocator org.apache.hadoop.net.TestSwitchMapping org.apache.hadoop.ha.TestShellCommandFencer org.apache.hadoop.jmx.TestJMXJsonServlet org.apache.hadoop.io.TestBloomMapFile org.apache.hadoop.io.compress.TestCodecFactory org.apache.hadoop.io.TestSequenceFileSerialization org.apache.hadoop.ipc.TestRPCCompatibility org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem org.apache.hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays org.apache.hadoop.http.TestPathFilter org.apache.hadoop.net.TestStaticMapping org.apache.hadoop.ipc.TestIPCServerResponder org.apache.hadoop.security.TestDoAsEffectiveUser org.apache.hadoop.http.TestServletFilter org.apache.hadoop.http.TestHttpServer +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1008//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1008//console This message is automatically generated. > Improve exception message when Configuration.set() is called with a null key or value > ------------------------------------------------------------------------------------- > > Key: HADOOP-8362 > URL: https://issues.apache.org/jira/browse/HADOOP-8362 > Project: Hadoop Common > Issue Type: Improvement > Components: conf > Affects Versions: 2.0.0 > Reporter: Todd Lipcon > Priority: Trivial > Labels: newbie > Attachments: HADOOP-8362-1.patch, HADOOP-8362-2.patch, HADOOP-8362.patch > > > Currently, calling Configuration.set(...) with a null value results in a NullPointerException within Properties.setProperty. We should check for null key/value and throw a better exception. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira