Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 24 May 2012 01:37:40 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <1134597758.14458.1337823460925.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1822203640.5902.1337644061056.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HADOOP-8422) Deprecate FileSystem#getDefault*
 and getServerDefault methods that don't take a Path argument
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282108#comment-13282108 ] 

Hadoop QA commented on HADOOP-8422:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528824/hadoop-8422.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified test files.

    -1 javac.  The applied patch generated 1997 javac compiler warnings (more than the trunk's current 1972 warnings).

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs:

                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1026//testReport/
Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1026//artifact/trunk/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1026//console

This message is automatically generated.
                
> Deprecate FileSystem#getDefault* and getServerDefault methods that don't take a Path argument 
> ----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8422
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8422
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hadoop-8422.txt
>
>
> The javadocs for FileSystem#getDefaultBlockSize and FileSystem#getDefaultReplication claim that "The given path will be used to locate the actual filesystem" however they both ignore the path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira