hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8344) Improve test-patch to make it easier to find javadoc warnings
Date Thu, 03 May 2012 15:22:51 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267494#comment-13267494
] 

Robert Joseph Evans commented on HADOOP-8344:
---------------------------------------------

Talking with Tom White about this on a different JIRA the original idea was to remove OK_JAVADOCS
entirely.  Javadocs are something that should always be simple to fix before checking in a
patch.  There really should never be any OK javadoc warnings.  There is one exception for
this in that when we use sun internal APIs javadoc spits out a warning that we cannot really
fix.  There are currently only 6 of these.  I am OK with putting in a framework to filter
the warnings more explicitly, and on a per project basis. This comment is just to give some
context on the changes made so far and the reasoning for the direction we have been going
in.
                
> Improve test-patch to make it easier to find javadoc warnings
> -------------------------------------------------------------
>
>                 Key: HADOOP-8344
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8344
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Todd Lipcon
>            Priority: Minor
>
> Often I have to spend a lot of time digging through logs to find javadoc warnings as
the result of a test-patch. Similar to the improvement made in HADOOP-8339, we should do the
following:
> - test-patch should only run javadoc on modules that have changed
> - the exclusions "OK_JAVADOC" should be per-project rather than cross-project
> - rather than just have a number, we should check in the actual list of warnings to ignore
and then fuzzy-match the patch warnings against the exclude list.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message