hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (HADOOP-8230) Enable sync by default and disable append
Date Wed, 02 May 2012 04:47:02 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266339#comment-13266339
] 

Eli Collins edited comment on HADOOP-8230 at 5/2/12 4:46 AM:
-------------------------------------------------------------

Thanks for chiming in Suresh.

Wrt #1 see [this comment in HDFS-3120|https://issues.apache.org/jira/browse/HDFS-3120?focusedCommentId=13241903&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13241903]
that outlines the proposal that Todd, Nicholas and I thought was best. Feel free to file a
follow-on jira for an improvement, happy to review. I'll update the description to match the
proposal.

Wrt #2 personally I don't think we should allow people to disable durable sync as that can
result in data loss for people running HBase. See HADOOP-8230 for more info. I'm open to having
an option to disable durable sync if you think that use case is important.

Wrt #3 the rationale was two-fold: (1) there are tests that are using append not to test append
per se but for the side effects and we'd lose sync test coverage by removing those tests and
(2) per the description we're keeping the append code path in case someone wants to fix the
data loss issues in which case it makes sense to keep the test coverage as well.
                
      was (Author: eli2):
    Thanks for chiming in Suresh.

Wrt #1 see [this comment in HDFS-3120|https://issues.apache.org/jira/browse/HDFS-3120?focusedCommentId=13241903&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13241903]
that outlines the proposal that Todd, Nicholas and I thought was best. Feel free to file a
follow-on jira for an improvement.

Wrt #2 add a new option to disable durable sync? Personally I don't think we should HADOOP-8230

                  
> Enable sync by default and disable append
> -----------------------------------------
>
>                 Key: HADOOP-8230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8230
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 1.1.0
>
>         Attachments: hadoop-8230.txt
>
>
> Per HDFS-3120 for 1.x let's:
> - Always enable the sync path, which is currently only enabled if dfs.support.append
is set
> - Remove the dfs.support.append configuration option. We'll keep the code paths though
in case we ever fix append on branch-1, in which case we can add the config option back

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message