hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23
Date Wed, 09 May 2012 15:55:52 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271501#comment-13271501
] 

Robert Joseph Evans commented on HADOOP-8373:
---------------------------------------------

The patch looks good to me.  My only concern is that it looks like you added in a test that
was not a part of the original code.  I would be great to have that test on more then just
branch-0.23  Other then that +1. It compiles and passed my tests.

I'll check the current patch into branch-0.23 now, and assuming you get a patch up for the
test I'll throw that into trunk/branch-2 too.
                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23
does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message