hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8434) TestConfiguration currently has no tests for direct setter methods
Date Wed, 30 May 2012 07:13:24 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285448#comment-13285448
] 

Harsh J commented on HADOOP-8434:
---------------------------------

Thanks for the patch. I have just one code-style related nit:

bq. assertEquals(value,configuration.getBoolean("value",false));

As seen in the above example, please provide spaces between arguments as per the Sun coding
guidelines we follow for Apache Hadoop.

Otherwise, looks good. +1 pending new patch and a jenkins re-run.
                
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8434
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8434
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: madhukara phatak
>              Labels: newbie
>         Attachments: HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better
to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for
the each of the setter methods, although other projects' tests do test this extensively.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message