hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj K (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8351) Add exclude/include file , need restart NN or RM.
Date Fri, 04 May 2012 04:41:01 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268120#comment-13268120
] 

Devaraj K commented on HADOOP-8351:
-----------------------------------

Thanks Xieguiming for the patch.

There are few of my observations about the patch.

* Changes have done in mapreduce code, can we move this jira to mapreduce project. As description
says it is for NN also, raise a new jira for hdfs.

* I don't think it will work, because if we want to get the updated values for 'yarn.resourcemanager.nodes.include-path'
and 'yarn.resourcemanager.nodes.exclude-path', need to reload the configuration.

* There are some chinese characters have come in the patch, can we avoid them.
                
> Add exclude/include file , need restart NN or RM.
> -------------------------------------------------
>
>                 Key: HADOOP-8351
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8351
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.23.1
>         Environment: suse
>            Reporter: xieguiming
>         Attachments: HADOOP-835-0.patch, HADOOP-835.patch
>
>
> "yarn.resourcemanager.nodes.include-path" default value is "", if we need add one include
file. and we must restart the RM. 
> I suggest that adding one include or exclude file, no need restart the RM. only execute
the refresh command.
> NN is the same.
> Modify the HostsFileReader class:
> public HostsFileReader(String inFile, 
>                          String exFile)
> to
>  public HostsFileReader(Configuration conf, 
>                          String NODES_INCLUDE_FILE_PATH,String DEFAULT_NODES_INCLUDE_FILE_PATH,
>                         String NODES_EXCLUDE_FILE_PATH,String DEFAULT_NODES_EXCLUDE_FILE_PATH)
> and thus, we can read the config file dynamic. and no need to restart the NM/NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message