hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7818) DiskChecker#checkDir should fail if the directory is not executable
Date Fri, 18 May 2012 22:27:08 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279261#comment-13279261
] 

Eli Collins commented on HADOOP-7818:
-------------------------------------

Actually, looking closer, testCheckDir_notExecutable is the same as the following test, it
and the new test pass w/o this change. Can you come up with a change that fails w/o your fix
and passes with it? Looks like there may be an issue with the mocking in the tests/_checkDirs.
                
> DiskChecker#checkDir should fail if the directory is not executable
> -------------------------------------------------------------------
>
>                 Key: HADOOP-7818
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7818
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Eli Collins
>            Assignee: madhukara phatak
>            Priority: Minor
>         Attachments: HADOOP-7818-1.patch, HADOOP-7818.patch
>
>
> DiskChecker#checkDir fails if a directory can't be created, read, or written but does
not fail if the directory exists and is not executable. This causes subsequent code to think
the directory is OK but later fail due to an inability to access the directory (eg see MAPREDUCE-2921).
I propose checkDir fails if the directory is not executable. Looking at the uses, this should
be fine, I think it was ignored because checkDir is often used to create directories and it
creates executable directories.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message