hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8230) Enable sync by default and disable append
Date Thu, 03 May 2012 06:25:57 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267242#comment-13267242
] 

Eli Collins commented on HADOOP-8230:
-------------------------------------

bq. For testing sync, with this patch, since it is enabled by default, you do not need the
flag right?

Correct, after my patch the tests that no longer use append no longer set the append flag.
The tests that call append to get its side effects still use the append flag.

Agree w Stack wrt the previous comment.  Making sync actually work is a bug fix, it was a
bug that we allowed people to call sync and unlike append there wasn't a flag to enable it
that was disabled by default. Better to fix the default behavior (which allows you to sync).
                
> Enable sync by default and disable append
> -----------------------------------------
>
>                 Key: HADOOP-8230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8230
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 1.1.0
>
>         Attachments: hadoop-8230.txt
>
>
> Per HDFS-3120 for 1.x let's:
> - Always enable the sync path, which is currently only enabled if dfs.support.append
is set
> - Remove the dfs.support.append configuration option. We'll keep the code paths though
in case we ever fix append on branch-1, in which case we can add the config option back

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message