hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8422) FileSystem#getDefaultBlockSize and Replication don't use the given path
Date Wed, 23 May 2012 16:32:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281708#comment-13281708

Harsh J commented on HADOOP-8422:

bq. I'm confused by the concern with the methods being non-static.

Ah its not a big concern, just a neatness thing.

I meant, if one were to call:

SomeUtilsClass.getDefaultReplication(Path), a static method, and this were to do: Path.getFileSystem().getDefaultReplication()
or so, that makes more correct sense (i.e. user is expecting Path to evaluate to the right
FS via this static call).

However, here we do:

fileSystem.getDefaultReplication(Path), wherein a user already has a proper fileSystem instance
- so may not feel the need to supply a path as well.

But this is just a nit, probably not worth changing things for now. So long as there's docs
that explain why its around for, its alright.
> FileSystem#getDefaultBlockSize and Replication don't use the given path
> -----------------------------------------------------------------------
>                 Key: HADOOP-8422
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8422
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 1.0.3
>            Reporter: Eli Collins
>            Priority: Minor
> The javadocs for FileSystem#getDefaultBlockSize and FileSystem#getDefaultReplication
claim that "The given path will be used to locate the actual filesystem" however they both
ignore the path.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message