hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8316) Audit logging should be disabled by default
Date Fri, 11 May 2012 16:40:49 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273409#comment-13273409
] 

Hadoop QA commented on HADOOP-8316:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12526538/hadoop-8316.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/984//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/984//console

This message is automatically generated.
                
> Audit logging should be disabled by default
> -------------------------------------------
>
>                 Key: HADOOP-8316
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8316
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hadoop-8316.txt
>
>
> HADOOP-7633 made hdfs, mr and security audit logging on by default (INFO level) in log4j.properties
used for the packages, this then got copied over to the non-packaging log4j.properties in
HADOOP-8216 (which made them consistent).
> Seems like we should keep with the v1.x setting which is disabled (WARNING level) by
default. There's a performance overhead to audit logging, and HADOOP-7633 provided not rationale
(just "We should add the audit logs as part of default confs") as to why they were enabled
for the packages.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message