hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8351) Add exclude/include file , need restart NN or RM.
Date Fri, 04 May 2012 03:46:55 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268094#comment-13268094
] 

Hadoop QA commented on HADOOP-8351:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525559/HADOOP-835-0.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/937//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/937//console

This message is automatically generated.
                
> Add exclude/include file , need restart NN or RM.
> -------------------------------------------------
>
>                 Key: HADOOP-8351
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8351
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.23.1
>         Environment: suse
>            Reporter: xieguiming
>         Attachments: HADOOP-835-0.patch, HADOOP-835.patch
>
>
> "yarn.resourcemanager.nodes.include-path" default value is "", if we need add one include
file. and we must restart the RM. 
> I suggest that adding one include or exclude file, no need restart the RM. only execute
the refresh command.
> NN is the same.
> Modify the HostsFileReader class:
> public HostsFileReader(String inFile, 
>                          String exFile)
> to
>  public HostsFileReader(Configuration conf, 
>                          String NODES_INCLUDE_FILE_PATH,String DEFAULT_NODES_INCLUDE_FILE_PATH,
>                         String NODES_EXCLUDE_FILE_PATH,String DEFAULT_NODES_EXCLUDE_FILE_PATH)
> and thus, we can read the config file dynamic. and no need to restart the NM/NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message