hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
Date Thu, 17 May 2012 03:02:37 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277515#comment-13277515
] 

Hadoop QA commented on HADOOP-8406:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12527752/hadoop-8406.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/999//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/999//console

This message is automatically generated.
                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize
when we iterate over it, or we need to materialize it during class-loading time by copying
to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message