hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8375) test-patch should stop immediately once it has found compilation errors
Date Wed, 09 May 2012 22:17:48 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271875#comment-13271875
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-8375:
------------------------------------------------

How about we also move the javadoc check after javac?
{code}
@@ -903,7 +903,12 @@
 checkJavadocWarnings
 (( RESULT = RESULT + $? ))
 checkJavacWarnings
-(( RESULT = RESULT + $? ))
+JAVAC_RET=$?
...
{code}

                
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-8375
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8375
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile.
 It was the behavior previously if I remember correctly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message