hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8172) Configuration no longer sets all keys in a deprecated key list.
Date Fri, 04 May 2012 13:28:48 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268353#comment-13268353
] 

Harsh J commented on HADOOP-8172:
---------------------------------

This patch seems to have caused two new Javadocs warnings to appear in the aftermath apparently:

{code}
[WARNING] Javadoc Warnings
[WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:334:
warning - Tag @link: missing '#': "addDeprecation(String key, String newKey)"
[WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:285:
warning - Tag @link: missing '#': "addDeprecation(String key, String newKey,
[WARNING] String customMessage)"
{code}

I've filed HADOOP-8359 to address these.
                
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
>                 Key: HADOOP-8172
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8172
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.23.3, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Anupam Seth
>            Priority: Critical
>             Fix For: 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent
test failure. The patch appears to have changed the following code (I am just paraphrasing
the code)
> {code}
> if(!deprecated(key)) {
>   set(key, value);
> } else {
>   for(String newKey: depricatedKeyMap.get(key)) {
>     set(newKey, value);
>   }
> }
> {code}
> to be 
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
>    set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
>    set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one
in the list will be set, where as previously all of them would be set.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message