Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Mon, 2 Apr 2012 15:41:23 +0000 (UTC)
From: "John George (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <882644587.888.1333381283952.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1163108800.4085.1328208654295.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
 implement getDefaultBlockSize, getDefaultReplication, getContentSummary
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244266#comment-13244266 ] 

John George commented on HADOOP-8014:
-------------------------------------

Thanks for looking at the patch again Daryn - always appreciate your input. About moving the behavior to {{FilterFileSystem}}, I was thinking the other way round - I feel it is better to keep the behavior in {{ChrootFileSystem}} since, as of now, it is the characteristic of {{ChrootFileSystem}} to have a {{path}}. Anyone inheriting {{FilterFileSystem}} should probably implement the same behavior like you said. 

Other than this being a debatable change (since it could be either way), do you actually see a defect or an issue in this change? 
                
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8014
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8014
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.23.0, 0.23.2, 0.24.0
>            Reporter: Daryn Sharp
>            Assignee: John George
>         Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}.  This causes files to be created with incorrect values.  The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point.  These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira