Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 24F2699C7 for ; Sun, 1 Apr 2012 19:54:51 +0000 (UTC) Received: (qmail 92738 invoked by uid 500); 1 Apr 2012 19:54:50 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 92686 invoked by uid 500); 1 Apr 2012 19:54:50 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 92677 invoked by uid 99); 1 Apr 2012 19:54:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Apr 2012 19:54:50 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Apr 2012 19:54:48 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id AAA71352586 for ; Sun, 1 Apr 2012 19:54:27 +0000 (UTC) Date: Sun, 1 Apr 2012 19:54:27 +0000 (UTC) From: "Aaron T. Myers (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <652768060.3634.1333310067711.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1337183286.3576.1333307547817.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-8238) NetUtils#getHostNameOfIP blows up if given ip:port string w/o port MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243828#comment-13243828 ] Aaron T. Myers commented on HADOOP-8238: ---------------------------------------- +1, the patch looks good to me. > NetUtils#getHostNameOfIP blows up if given ip:port string w/o port > ------------------------------------------------------------------ > > Key: HADOOP-8238 > URL: https://issues.apache.org/jira/browse/HADOOP-8238 > Project: Hadoop Common > Issue Type: Bug > Reporter: Eli Collins > Assignee: Eli Collins > Attachments: hadoop-8238.txt > > > NetUtils#getHostNameOfIP blows up if not given a string of form ip:port, because the regex matches the port optionally but the code requires a semicolon. It also doesn't check the given string for null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira