Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 4 Apr 2012 02:36:22 +0000 (UTC)
From: "Aaron T. Myers (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <556877883.10017.1333506982163.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <848343800.8117.1333483103905.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-8244) Improve comments on
 ByteBufferReadable.read
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245971#comment-13245971 ] 

Aaron T. Myers commented on HADOOP-8244:
----------------------------------------

Patch looks pretty good to me, Henry. One little comment:

# "After the call, buf.position() and buf.limit() should be unchanged..." - perhaps change this to "after a successful call" ?
                
> Improve comments on ByteBufferReadable.read
> -------------------------------------------
>
>                 Key: HADOOP-8244
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8244
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>         Attachments: HADOOP-8244.0.patch
>
>
> There are a couple of ways in which the comment on ByteBufferReadable.read can be improved. Since this is a public-facing API with potentially many implementations, it's worth taking the time to get it right.
> * We should describe what can become of the byte buffer state in the case of an exception (is the limit changed? where's the position?). For the DFSInputStream implementation, position and limit are unchanged if there is an error, but I don't think that's the right think to mandate for all implementations. 
> * We should mention explicitly that 0-byte reads are legitimate - this is particularly important in light of HDFS-3110 which detects support for direct reads by issuing a 0-byte read from libhdfs. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira