Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 11 Apr 2012 23:57:17 +0000 (UTC)
From: "Eli Collins (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <203457330.15357.1334188637872.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1153021670.15184.1334186357083.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-8270) hadoop-daemon.sh stop action is
 not LSB compliant
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252062#comment-13252062 ] 

Eli Collins commented on HADOOP-8270:
-------------------------------------

+1  looks good, the test failure is unrelated, no new test since it's the daemon.sh script.
                
> hadoop-daemon.sh stop action is not LSB compliant
> -------------------------------------------------
>
>                 Key: HADOOP-8270
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8270
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.23.1
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: HADOOP-8270.patch.txt
>
>
> The following bit of code from hadoop-daemon.sh is not LSB compliant, since
> according to http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
> a stop action on an already stopped service should return 0.
> {noformat}
>  (stop)
>     if [ -f $pid ]; then
>       if kill -0 `cat $pid` > /dev/null 2>&1; then
>         echo stopping $command
>         kill `cat $pid`
>       else
>         echo no $command to stop
>         exit 1
>       fi
>     else
>       echo no $command to stop
>       exit 1
>     fi
>     ;;
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira