Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A48F590B7 for ; Wed, 4 Apr 2012 19:30:45 +0000 (UTC) Received: (qmail 25998 invoked by uid 500); 4 Apr 2012 19:30:45 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 25961 invoked by uid 500); 4 Apr 2012 19:30:45 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 25953 invoked by uid 99); 4 Apr 2012 19:30:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2012 19:30:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2012 19:30:44 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 0CE6D3584AD for ; Wed, 4 Apr 2012 19:30:24 +0000 (UTC) Date: Wed, 4 Apr 2012 19:30:24 +0000 (UTC) From: "Robert Joseph Evans (Updated) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1036330483.13550.1333567824054.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HADOOP-6963) Fix FileUtil.getDU. It should not include the size of the directory or follow symbolic links MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans updated HADOOP-6963: ---------------------------------------- Target Version/s: 1.0.3, 0.23.3 (was: 0.23.3, 1.0.3) Status: Open (was: Patch Available) Kicking Jenkins > Fix FileUtil.getDU. It should not include the size of the directory or follow symbolic links > -------------------------------------------------------------------------------------------- > > Key: HADOOP-6963 > URL: https://issues.apache.org/jira/browse/HADOOP-6963 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Affects Versions: 0.23.1, 0.20.205.0 > Reporter: Owen O'Malley > Assignee: Ravi Prakash > Priority: Critical > Attachments: HADOOP-6963.branch-1.0.2.patch, HADOOP-6963.branch-23.patch > > > The getDU method should not include the size of the directory. The Java interface says that the value is undefined and in Linux/Sun it gets the 4096 for the inode. Clearly this isn't useful. > It also recursively calls itself. In case the directory has a symbolic link forming a cycle, getDU keeps spinning in the cycle. In our case, we saw this in the org.apache.hadoop.mapred.JobLocalizer.downloadPrivateCacheObjects call. This prevented other tasks on the same node from committing, causing the TT to become effectively useless (because the JT thinks it already has enough tasks running) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira