hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Date Thu, 05 Apr 2012 17:16:30 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247383#comment-13247383
] 

Suresh Srinivas commented on HADOOP-8014:
-----------------------------------------

Nice work.

Most of these are minor comments.
# FileSystem#getServerDefaults() - is it better to day path p is used for identifying a destination
file system? Same for FileSystem#getDefaultReplication(path). Perhaps adding information like
a FileSystem could have another file system or file systems it could be delegating the call
to. Path helps identifying the underlying file system?
# Please move NotInMountException to a separate java file
# FileSystemTestHelper#createParent not used in createFile() method. Do you need multiple
overloaded variants of that method?

                
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication,
getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8014
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8014
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.23.0, 0.23.2, 0.24.0
>            Reporter: Daryn Sharp
>            Assignee: John George
>         Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch,
HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}}
and {{getDefaultReplication()}}.  This causes files to be created with incorrect values. 
The problem is that the current apis are insufficient for viewfs because the defaults depend
on the underlying mount point.  These methods need counterparts that accept a {{Path}} so
viewfs can resolve the mount point for a path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message