hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8310) FileContext#checkPath should handle URIs with no port
Date Tue, 24 Apr 2012 08:57:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260367#comment-13260367

Hadoop QA commented on HADOOP-8310:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    -1 core tests.  The patch failed these unit tests:

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/884//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/884//console

This message is automatically generated.
> FileContext#checkPath should handle URIs with no port
> -----------------------------------------------------
>                 Key: HADOOP-8310
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8310
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.0.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HADOOP-8310.patch
> AbstractFileSystem#checkPath is used to verify that a given path is for the same file
system as represented by the AbstractFileSystem instance.
> The original intent of the code was to allow for no port to be provided in the checked
path, if the default port was being used by the AbstractFileSystem instance. However, before
performing port handling, AFS#checkPath compares the full URI authorities for equality. Since
the URI authority includes the port, the port handling code is never reached, and thus valid
paths may be erroneously considered invalid.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message