hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8248) Clarify bylaws about review-then-commit policy
Date Thu, 05 Apr 2012 20:28:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247625#comment-13247625

Tsz Wo (Nicholas), SZE commented on HADOOP-8248:

Since thare are an on-going mailing discussion thead and a JIRA, it is better to also post
my email reply here.
I agree that the bylaws is not clear about this.  For reviewing patches, my understanding
is that any contributor, a committer or not, could review patches and the +1 counts.  I have
worked on Hadoop almost five years.  This is what we are doing for a long time (if it is not
from the beginning of the Hadoop project.)  Could other people confirm this?

>From the [HowToContribute wiki|http://wiki.apache.org/hadoop/HowToContribute], it does
advise committers to find another committer to review difficult patches: "Committers: for
non-trivial changes, it is best to get another committer to review your patches before commit.
..."  It seems saying that it is okay for non-committers reviewing simple and medium patches.
 Todd's amendments use different wording which seems implying a different requirement: the
+1's from non-committers could be counted only for simple patches but not medium and difficult

I think we should keep allowing everyone to review patches.  It slows down the development
and is discouraging if non-committer's +1 does not count.  I believe the judgement of the
committer who commits the patch won't commit bad code.  We have svn and we could revert patches
if necessary.  Lastly, if a committer keeps committing bad code, we could exercise "Committer

BTW, does anyone know what other Apache projects do?

> Clarify bylaws about review-then-commit policy
> ----------------------------------------------
>                 Key: HADOOP-8248
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8248
>             Project: Hadoop Common
>          Issue Type: Task
>            Reporter: Todd Lipcon
>         Attachments: proposed-bylaw-change.txt
> As discussed on the mailing list (thread "Requirements for patch review" 4/4/2012) we
should clarify the bylaws with respect to the review-then-commit policy. This JIRA is to agree
on the proposed change.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message