hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8270) hadoop-daemon.sh stop action should return 0 for an already stopped service
Date Thu, 12 Apr 2012 00:47:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252100#comment-13252100
] 

Hudson commented on HADOOP-8270:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2070 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2070/])
    HADOOP-8270. hadoop-daemon.sh stop action should return 0 for an already stopped service.
Contributed by Roman Shaposhnik (Revision 1325069)

     Result = ABORTED
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325069
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh

                
> hadoop-daemon.sh stop action should return 0 for an already stopped service 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-8270
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8270
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.23.1
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8270.patch.txt
>
>
> The following bit of code from hadoop-daemon.sh is not LSB compliant, since
> according to http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
> a stop action on an already stopped service should return 0.
> {noformat}
>  (stop)
>     if [ -f $pid ]; then
>       if kill -0 `cat $pid` > /dev/null 2>&1; then
>         echo stopping $command
>         kill `cat $pid`
>       else
>         echo no $command to stop
>         exit 1
>       fi
>     else
>       echo no $command to stop
>       exit 1
>     fi
>     ;;
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message