hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8323) Revert HADOOP-7940 and improve javadocs and test for Text.clear()
Date Mon, 30 Apr 2012 19:05:48 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265116#comment-13265116
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-8323:
------------------------------------------------

Hi Harsh,

You can do it by 
{noformat}
$svn merge -c -1295061 .
--- Reverse-merging r1295061 into 'hadoop-common-project/hadoop-common/CHANGES.txt':
U    hadoop-common-project/hadoop-common/CHANGES.txt
--- Reverse-merging r1295061 into '.':
U    hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
--- Reverse-merging r1295061 into 'hadoop-common-project/hadoop-common/src/main/java':
U    hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
{noformat}

Yes, the right thing is to first revert r1295061 and the commits to the branches, and then
commit the new javadoc/test changes.
                
> Revert HADOOP-7940 and improve javadocs and test for Text.clear()
> -----------------------------------------------------------------
>
>                 Key: HADOOP-8323
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8323
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Critical
>              Labels: performance
>         Attachments: HADOOP-8323.patch, HADOOP-8323.patch
>
>
> Per [~jdonofrio]'s comments on HADOOP-7940, we should revert it as it has caused a performance
regression (for scenarios where Text is reused, popular in MR).
> The clear() works as intended, as the API also offers a current length API.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message