hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8230) Enable sync by default and disable append
Date Mon, 30 Apr 2012 19:51:49 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265151#comment-13265151
] 

Suresh Srinivas commented on HADOOP-8230:
-----------------------------------------

Eli, sorry for the late comment. I agree with the general direction of splitting hflush/hsync
feature from append. Perhaps these features should be using two different flags.  

I have concerns with this change:
# I thought the proposal from HDFS-3120 was to add "dfs.support.sync". I do not see that flag
in this patch.
# There are installations where hsync/hflush is disabled, using dfs.support.append. That option
should be preserved.
# "dfs.support.broken.append" - why add this and not delete the tests that are testing append
functionality?
                
> Enable sync by default and disable append
> -----------------------------------------
>
>                 Key: HADOOP-8230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8230
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 1.1.0
>
>         Attachments: hadoop-8230.txt
>
>
> Per HDFS-3120 for 1.x let's:
> - Always enable the sync path, which is currently only enabled if dfs.support.append
is set
> - Remove the dfs.support.append configuration option. We'll keep the code paths though
in case we ever fix append on branch-1, in which case we can add the config option back

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message